search

Tomm0017 / rsmod

New repository: https://github.com/rsmod/rsmod
https://github.com/rsmod/rsmod
Apache License 2.0
125 stars 101 forks source link

NPC Drops #8

Open Tomm0017 opened 5 years ago

Tomm0017 commented 5 years ago

Add a drop system for npcs

notmeta commented 5 years ago

I'd suggest making a DSL for this which would allow for all sorts of possibilities which are not possible to represent in JSON, such as dropping an item with a given rarity if a particular quest is at a certain stage while wielding a specific item.

That being said since kotlinscript is heavily used already perhaps drops could be done using kts plugins instead.

Tomm0017 commented 5 years ago

@notmeta Been thinking of the best way to approach it. A global npc drop system may not be worth it, but still thinking it over. It's either

1) Define all drops as plugins in KotlinScript (similar to how all drops are defined on 07) 2) Define "misc" drops for npcs externally and handle complex drops through plugins

notmeta commented 5 years ago

@notmeta It's either

1. Define all drops as plugins in KotlinScript (similar to how all drops are defined on 07)

2. Define "misc" drops for npcs externally and handle complex drops through plugins

@Tomm0017 Personally I'd keep them all in one place and go for the former choice. It might be the more cumbersome option but it keeps users asking "I can't find the drops for X" and emulating what RS does is the best choice when... emulating RS

Tomm0017 commented 5 years ago

@notmeta I was also leaning towards that option, so will probably move forward with that. Thanks for the feedback!