search

Tomme / dbt-athena

The athena adapter plugin for dbt (https://getdbt.com)
Apache License 2.0
142 stars 79 forks source link

Add optional aws_profile_name to adapter config #20

Closed DJLemkes closed 3 years ago

DJLemkes commented 3 years ago

Let me start by saying thanks for the amazing work on the adapter. Really enjoying it!

This PR allows pointing a DBT profile to a specific AWS profile without managing the AWS_PROFILE environment variable separately.

Example: consider a situation where I want to run the same DBT project against different AWS accounts (e.g. dev, prd). For both accounts I have credentials in my ~/.aws/credentials file in different profiles (e.g. [dev] and [prd]). Currently, I have to run export AWS_PROFILE=<profile_name> before starting my dbt run to make this work, which is very error-prone.

DJLemkes commented 3 years ago

@Tomme, what are your thoughts on this?

Tomme commented 3 years ago

@Tomme, what are your thoughts on this?

Thanks a lot for the contribution and I very much welcome this change! I will give it a test and aim to get it merged within several days 👍