search

Tomme / dbt-athena

The athena adapter plugin for dbt (https://getdbt.com)
Apache License 2.0
140 stars 79 forks source link

Tables not cleaned up if materialized = table and static external location #54

Closed ojaved-equip closed 2 years ago

ojaved-equip commented 2 years ago

Looks like issue was caused by this merge: https://github.com/Tomme/dbt-athena/pull/43

If we have a static external location and materialized = table (for full overwrite), the prior data in the external location is not cleaned up.

courentin commented 2 years ago

Thank you for this issue, I'm having the same error, I think https://github.com/Tomme/dbt-athena/pull/49 is fixing this issue

nialloriordan commented 2 years ago

@courentin @ojaved-equip I have created a new PR #73 that fixes this issue.

Thank you to @datalytics1 for the original PR