search

Tomme / dbt-athena

The athena adapter plugin for dbt (https://getdbt.com)
Apache License 2.0
140 stars 79 forks source link

relax boto3 version requirements #65

Closed jankatins closed 2 years ago

jankatins commented 2 years ago

The boto3 version requirement currently means you have to use an old version of the awscli if you install both into the same venv. That in turn means that aws sso does not work properly. It would be nice if the install requirement in setup.py could be changed to >= to allow installing higher versions and assume that higher versions are not breaking API (until proven otherwise...).

E.g. 

    install_requires=[
        "dbt-core>=1.0",
        "pyathena>=2.2.0",
        "boto3>=1.18.12",
        "tenacity>=6.3.1",
    ]

It's then up to the user to ensure that the installed versions produce a working set of packages.

cgomez238 commented 2 years ago

I would like to emphasize this request as I am having issues using the dagster-aws library. There seems to be a bug in boto3 1.18.12 that conflicts with this library, and I am having a hard time finding a workaround.

Antauri commented 2 years ago

Same here ... Can't use awswrangler and dbt-athena in the same Dagster/dagit project because of the equal (pip-compile requirements.in with both dbt-athena and awswrangler)

  boto3==1.18.12 (from dbt-athena==1.0.1->-r requirements.in (line 14))
  boto3<2.0.0,>=1.20.17 (from awswrangler==2.14.0->-r requirements.in (line 13))
ConstantinoSchillebeeckx commented 2 years ago

Adding another voice to the pile; looks like the last installable version of awswrangler is 2.12.1

ConstantinoSchillebeeckx commented 2 years ago

@Tomme this issue can now be closed; thank you!