Tomme / dbt-athena

The athena adapter plugin for dbt (https://getdbt.com)
Apache License 2.0
142 stars 79 forks source link

Update requirements.txt #71

Closed Antauri closed 2 years ago

Antauri commented 2 years ago
  boto3==1.18.12 (from dbt-athena==1.0.1->-r requirements.in (line 14))
  boto3<2.0.0,>=1.20.17 (from awswrangler==2.14.0->-r requirements.in (line 13))

Maybe allowing it to work with awswrangler.

jankatins commented 2 years ago

I think you have to update the version constraints in setup.py: these (as far as I know) will be the relevant ones when installing it as a dependency.

jankatins commented 2 years ago

My understanding of dependencies in requirements.txt and setup.py is the following:

Going by that and seeing that requirements.txt is used in the Makefile(so more in a deployment mode), I would currently only touch setup.py for now and then wait for @Tomme to say if the requirements.txt should also be adjusted.

ConstantinoSchillebeeckx commented 2 years ago

@Tomme can you take a look - I suspect this is going to be blocking for most people using this library along with libraries like awswrangler. discussion here