search

Tomme / dbt-athena

The athena adapter plugin for dbt (https://getdbt.com)
Apache License 2.0
140 stars 79 forks source link

Athena requires write_compression for parquet #94

Closed SOVALINUX closed 2 years ago

SOVALINUX commented 2 years ago

Fix for https://github.com/Tomme/dbt-athena/issues/93

julianste commented 2 years ago

GZIP as default would probably not work for ORC, see https://github.com/Tomme/dbt-athena/issues/93#issuecomment-1111236741.

92 should fix this by applying the Athena default w.r.t. the used format, if no write_compression is specified.

SOVALINUX commented 2 years ago

@julianste agreed. Thank you. Just saw that production is not working and applied first fix that came to my mind :) Agreed that https://github.com/Tomme/dbt-athena/pull/92 is better