search

TommyJones / tidylda

Implements an algorithim for Latent Dirichlet Allocation using style conventions from the [tidyverse](https://style.tidyverse.org/) and [tidymodels](https://tidymodels.github.io/model-implementation-principles/index.html).
Other
41 stars 3 forks source link

Use naming conventions to match STM #29

Closed TommyJones closed 4 years ago

TommyJones commented 4 years ago

As it stands, there are at several naming conventions for probabilistic topic models packages in the R ecosystem. This can be confusing to users. Partially this is due to the literature, that has failed to find consensus. I'm thinking that I need to make the following changes to get in line with at least STM, which is popular and promoted by tidytext.

I want to do more exploration to validate this. But the point is that I want to contribute to consolidation in naming.

TommyJones commented 4 years ago

Oh and "gamma" clashes with the topicmodels package. So maybe, lambda?

TommyJones commented 4 years ago

gamma --> lambda bd68abd4a72b3bfedecf7c6721369d210024ba2c

TommyJones commented 4 years ago

beta --> eta 35427b31430893a6f8c4fcc28a63c4300c7e5f89

TommyJones commented 4 years ago

phi --> beta 473656bdddbbcf56e27e84a54c5f84ea6e585a7b

I'll take any errors that pop up in cmd check as they come.