change `dtm` arguments to `data` - Githubissues

TommyJones / tidylda

Implements an algorithim for Latent Dirichlet Allocation using style conventions from the [tidyverse](https://style.tidyverse.org/) and [tidymodels](https://tidymodels.github.io/model-implementation-principles/index.html).

Other

41 stars 3 forks source link

change `dtm` arguments to `data` #37

Closed TommyJones closed 4 years ago

TommyJones commented 4 years ago

This would be more general as you can pass a DTM or TCM to these functions

TommyJones commented 4 years ago

Not 100% committed to doing this yet.

On the one hand, using "dtm" signals that you won't get this model to work with a tidy table from tidytext::unnest_tokens. On the other hand, you can use a TCM or DTM or any other number of ways of counting tokens. So, "dtm" in that regard is misleading. Hmmmm....

TommyJones commented 4 years ago

I've decided to do this, but only for user-facing functions.

TommyJones commented 4 years ago

8b53f8c8eaa88c5bae1f1a4eadff74f806f3f541

TommyJones commented 4 years ago

Actually done with a0a9e9d9952434748939a34d6fc106449f5531a6 as previous version didn't update readme and had compilation errors on other systems