search

TommyJones / tidylda

Implements an algorithim for Latent Dirichlet Allocation using style conventions from the [tidyverse](https://style.tidyverse.org/) and [tidymodels](https://tidymodels.github.io/model-implementation-principles/index.html).
Other
41 stars 3 forks source link

replace `format_raw_lda_outputs` with `new_tidylda` #43

Closed TommyJones closed 3 years ago

TommyJones commented 3 years ago

I think I missed the point of having a constructor function of the form new_x when I first wrote this part of the package.

The constructor is supposed to have the same functionality as format_raw_lda_outputs.

See: https://adv-r.hadley.nz/s3.html#s3-constructor

The purpose of constructors is to help you, the developer. [...] The constructor is a developer function: it will be called in many places, by an experienced user. That means it’s OK to trade a little safety in return for performance, and you should avoid potentially time-consuming checks in the constructor.

TommyJones commented 3 years ago

4cf02c56543fb7d7a71487bd14235b467ef9f044