search

TommyJones / tidylda

Implements an algorithim for Latent Dirichlet Allocation using style conventions from the [tidyverse](https://style.tidyverse.org/) and [tidymodels](https://tidymodels.github.io/model-implementation-principles/index.html).
Other
41 stars 3 forks source link

Remove textmineR dependencies #56

Closed TommyJones closed 2 years ago

TommyJones commented 2 years ago

When tidylda goes to CRAN, I want textmineR to depend on it and not the other way around. Cross-references will probably make CRAN yell at me. :)

IIRC, tidylda uses textmineR to

Need to verify all textmineR calls and add homegrown functionality for that in tidylda

TommyJones commented 2 years ago

Confirmed! tidylda only calls textmineR to calculate coherence(textmineR::CalcProbCoherence()) and to get top terms (textmineR::GetTopTerms())

TommyJones commented 2 years ago

https://github.com/TommyJones/tidylda/commit/a8c61c703e104e2d9c34ee073f155df45f44d6d5

Note that there are still data dependencies from textmineR. This is trivially fixable, so I will leave them unaddressed for now.