TommyJones / tidylda

Implements an algorithim for Latent Dirichlet Allocation using style conventions from the [tidyverse](https://style.tidyverse.org/) and [tidymodels](https://tidymodels.github.io/model-implementation-principles/index.html).
Other
41 stars 3 forks source link

Arguments that control computational aspects should be in a "control" object #68

Open TommyJones opened 2 years ago

TommyJones commented 2 years ago

See the tidymodels principles here.

This affects all three of tidylda, predict.tidylda, and refit.tidylda, where Gibbs control aspects should be in the control object. Moreover, I'd recommend setting default values for the sampler so a user could get basic functionality without having to monkey with the Gibbs sampler itself.