JOSS review: Comments on the paper

TommyJones / tidylda

Implements an algorithim for Latent Dirichlet Allocation using style conventions from the [tidyverse](https://style.tidyverse.org/) and [tidymodels](https://tidymodels.github.io/model-implementation-principles/index.html).

Other

41 stars 3 forks source link

JOSS review: Comments on the paper #76

Closed maximelenormand closed 4 days ago

maximelenormand commented 5 days ago

I have two general comments on the paper.

The summary should focus on your package and not on the tidy universe. Please use this section to describe the functionality and purpose of your package for a diverse, non-specialist audience.
The state of need/field section could be developed by listing the main packages that implement topic models in R (and other languages) and explaining in detail why your software is much better than the other options.

#6800

TommyJones commented 4 days ago

I believe I addressed these issues with this commit 6e8e2f53a43d360fa0324e445b09e43bbd6ef8a8

Can you confirm that's sufficient (or not)? I'll leave this issue open until then.

maximelenormand commented 4 days ago

That's fine by me. Thanks.

TommyJones commented 4 days ago

Awesome. Thank you so much for your time and effort in reviewing and making both the paper and the tidylda package better.