No Visual Studio / XCode project/solutions?

[thomthom]

Is there no projects set up for this wrapper?

I was going to look into setting up a PR for GoogleTest (https://github.com/TommyKaneko/Sketchup-API-C-Wrapper/commit/ffc704c243d8bba272c4064b46276227f5a27c0b#r27718155)

For that to happen there needs to be either a static or dynamic lib for which the GoogleTest project can link with. And I had also assumed that's how it would have been consumed.,

How are you currently using it? Adding all the files into the same projects you are using it with?

[TommyKaneko]

My project that I use it for is a private project.

I have an XCode project for the Cpp Wrapper, which outputs a dylib. For my private project, I have the CppWrapper as a subproject, so updates on CppWrapper can be rebuilt at the same time as my private project.

For the cpp files that I create, I include the header files from the CppWrapper like this: #include <SUAPI-CppWrapper/Geometry.hpp>

Shall I share the XCode project for this?

[thomthom]

To easily consume this wrapper library it would be nice to have projects for Visual Studio and Xcode that builds static libs. That way the user of the link can just add references to these static libs. (Similar to how you consume GoogleTest and other projects.)

Another snag I ran into when trying to set up a GoogleTest project, I needed to move the "SUAPI-CppWrapper" under a sub-directory to avoid conflating includes. My current dev branch I moved it to src/SUAPI-CppWrapper.

That's a rather common setup since a project typically needs tests as well as the source along side.

+ Project Root
  + src/
  + tests/
  + resources/

Ultimately it's up to you - but I'll try to set up an example of how it can be provided as a static lib with tests.

[thomthom]

I'm seeing some errors and warnings when building with VS2017:

[thomthom]

The #ifdef isn't working right:

[thomthom]

std::transform is missing the include header for it. (Another reason to keep the wrapper in a separate static lib so include paths doesn't get mixed up with other projects.)

[thomthom]

Might be worth enabling treating warnings as errors.

What is that piece of code doing? Is it capping rhs into the range of -2PI to +2PI? (If so, modulo might be an alternative.)

[TommyKaneko]

Thanks for your big review of the code today, ThomThom. I will get on all those issues over the next week!

[thomthom]

I think this should do the same - while avoiding the warnings.

My current dev branch is here: https://github.com/thomthom/Sketchup-API-C-Wrapper/tree/dev-vs-project

[TommyKaneko]

FYI - I have uploaded my XCode environment here: https://github.com/TommyKaneko/Sketchup-API-C-Wrapper/tree/xcode_project

[thomthom]

I've been looking into CMake recently to simplify cross platform development. Maybe a CMake project file could be useful for this project? VSCode and Visual Studio has nice integration with CMake.

[TommyKaneko]

I think you have already implemented this no: https://github.com/TommyKaneko/Sketchup-API-C-Wrapper/tree/master/cmake

[thomthom]

😱😵!!

I really have no recollection of doing that!

But I see there's a few TODO notes. And I've been reading up a book on CMake, diving into best practices and learning a lot more about it. So I'll probably come back and revisit this.

With GitHub having CI now we can set up test builds to test that the various project solutions work.

[TommyKaneko]

You were on autopilot! Nothing wrong with that. I am poorly informed on the compiler side of things, so I will have to trust you to get it right. Travis CI has been set up for this project for Doxygen generation: https://tommykaneko.github.io/Sketchup-API-C-Wrapper/html/

Feel free to add to it.