search

TommyKaneko / Sketchup-API-C-Wrapper

A complete set of C++ Wrapper classes for SketchUp C API objects
MIT License
29 stars 8 forks source link

Add test for reading a mixed-type TypedValue array #49

Closed jimfoltz closed 6 years ago

jimfoltz commented 6 years ago

Added test for reading mixed value TypedValue arrays from a model on disk. Added the test model to the models folder, but I'm not sure yet how to get the relative path to the model from the test code.

Reference #48

jimfoltz commented 6 years ago

So apprently the PR get's it's own number? Yeesh. Should I need to re-do this whole Issue/PR?

jimfoltz commented 6 years ago

This latest change ec11f54 has resolved the issue for me.

TommyKaneko commented 6 years ago

So you are saying that the problem you were experiencing was due to how the TypedValue array was being set? I thought the issue was with reading SUTypedValueGetArrayItems?

jimfoltz commented 6 years ago

So you are saying that the problem you were experiencing was due to how the TypedValue array was being set?

It appears so, yes.

I thought the issue was with reading SUTypedValueGetArrayItems?

I've reviewed the issue and test case in the pull request - I'm not sure why you had that impression.