TomodomoCo / total-slider

A WordPress plugin for creating, editing and removing ‘slides’ with text and images (for a homepage, for example).
GNU General Public License v2.0
7 stars 2 forks source link

Background images not binding #31

Closed chrisvanpatten closed 11 years ago

chrisvanpatten commented 12 years ago

There's currently an error with background images not properly binding, first reported in #28.

When selecting an image, the following error appears in the Web Inspector:

Uncaught TypeError: Cannot call method 'bind' of undefined /wp/wp-admin/media-upload.php?total-slider-uploader=bgimage&total-slider-slide-group-template=carbonview&total-slider-slide-group-template-location=theme&type=image&post_id=0&tab=library:53

And this pop-up is displayed on attempts to save:

Please correct the following errors with the form.

The supplied background image URL is not a valid URL.

The preview pane doesn't update with the image either, although interestingly the slide thumbnail in the slide navigator on the top does update properly.

PeterUpfold commented 12 years ago

Can you try this commit to see if it resolves this and/or #28?

chrisvanpatten commented 12 years ago

I still get this error, and because I can't save I can't check #28.

chrisvanpatten commented 12 years ago

Worth mentioning that I'm using the Media Library, not uploading a new image.

PeterUpfold commented 12 years ago

I personally couldn’t reproduce this issue anymore, except a possibly related, non-fatal uploader is undefined error on Media Library pages, but I’ve committed what should fix that.

If you still have no luck with that commit, some things to try:

chrisvanpatten commented 12 years ago

I'll send you the template.

The issue does persist with a newly created slide group with the same template, but it also persists with the default template.

The second I click "Media Library", I see this:

Uncaught TypeError: Cannot call method 'bind' of undefined
(anonymous function)
o
p.fireWith
e.extend.ready
c.addEventListener.B

I can also re-run this the debug scripts option.

EDIT: Here it is after running with SCRIPT_DEBUG set to true:

chrisvanpatten commented 12 years ago

I'm also getting a lot of Resource interpreted as Image but transferred with MIME type text/html warnings - could these be at all related or should I ignore them?

chrisvanpatten commented 12 years ago

Just for the public record, the last commit (ae25715ba11b027f033bf30b490c56cc0610da2f) fixes the error message but does not fix the problem. I'm currently thinking it's a problem with my installation, although backchannel consensus is to take some time away and step back in a day or so to see if we can reproduce it.

PeterUpfold commented 12 years ago

I have tried to reproduce this issue again, with the template, and I'm not having any problems uploading or selecting a background image. It's likely we'll have to take a look at the specific installation in question.

chrisvanpatten commented 12 years ago

I'll send you some info outside of Github.

chrisvanpatten commented 12 years ago

Bizarrely, this issue totally disappeared once I deployed to staging. Same browser, so we can rule out any browser bugs too. I'm going to chalk this one up to a mysterious bug that isn't worth pursuing, and close the issue.

PeterUpfold commented 11 years ago

Unless this turns out to be related to this issue with setting background images, I'm going to close this issue as suggested.

Clearly, in some rare cases there are weird things that happen with background images, but I’ve yet to find anything causal, or even any identifiable commonality between the issues. Hopefully we can get some more information, and I can reproduce one of these problems for myself, so the fixing process can begin!