search

TomodomoCo / total-slider

A WordPress plugin for creating, editing and removing ‘slides’ with text and images (for a homepage, for example).
GNU General Public License v2.0
7 stars 2 forks source link

Built-in templates for v1.1 #37

Closed PeterUpfold closed 12 years ago

PeterUpfold commented 12 years ago

We don't currently have a set of built-in Total Slider templates that will ship with v1.1. It would be great to have a modest selection of base templates to satisfy the slider design preferences of a good percentage of users.

I'm keen to try and get v1.1 out soon (without making promises I can't keep, I'd like to make next week about tidy up, testing and publishing). I'm conscious that the template features change a lot from v1.0.x to v1.1, and making sure fewer Total Slider users have to do an upgrade trasition from v1.0.x style templates to v1.1’s approach seems like fostering a good UX for those newer users.

We can, of course, ship new built-in templates in minor point releases too, so it doesn’t need to be a huge volume of templates; we can always augment the selection later.

chrisvanpatten commented 12 years ago

I'll have some of these for delivery tonight. Targeting 2-3 themes that work nicely with the WordPress default themes (at least Twenty Ten and Twenty Twelve, possibly Twenty Eleven as well).

PeterUpfold commented 12 years ago

Thank you for your efforts so far on this!

chrisvanpatten commented 12 years ago

Two themes down! They're both for Twenty Twelve, incidentally, but I think it's better than nothing so far. I'll work on tackling some Twenty Ten specific themes either later tonight or tomorrow, depending on how my energy holds out.

Twenty Twelve: Twenty Twelve

Twenty Twelve (Alternate) Twenty Twelve

twentytwelve-alt needs a bit of tweaking in the pager element that someone with more JavaScript experience than me may be able to tackle pretty easily. It's just a question of setting the "current" class in the right place. I have it working when you click on a specific element, but it doesn't work as it automatically advances.

Both themes are responsive, although the non-alternate version has trouble if you reposition the overlay. I tried to come up with a JavaScript solution to handle this, but couldn't figure out anything that would work automatically in all cases. This is something I need to give some thought and perhaps address in a point release.

I'll be cleaning up the markup, styles, and code in these a bit (trying to remove !important wherever possible for instance) and then I'll commit them and send each one in as a pull request.

chrisvanpatten commented 12 years ago

I'm going to close this issue as the two themes are now in place in the code. Both have a bit of cleanup left, but I'll set up separate issues for that stuff.