TomodomoCo / total-slider

A WordPress plugin for creating, editing and removing ‘slides’ with text and images (for a homepage, for example).
GNU General Public License v2.0
7 stars 2 forks source link

Total Slider interface is not functional when `rich_editing` user option is false #58

Closed PeterUpfold closed 11 years ago

PeterUpfold commented 11 years ago

When the call to get_user_option( 'rich_editing' ) returns false (i.e. the user prefers HTML editing to rich text editing), the Total Slider interface is not functional at all.

The offending line is total-slider.php:670, where the admin page JS references aren't printed to the output if rich text editing is enabled. These set variables which are only available PHP-side, so that the static JS can reference the location to jQuery, the TinyMCE popup, and other items. Failing to set these variables, by failing to include these files, causes the static JS to fail.

The inclusion of this file should not be conditional, to ensure these references are always available to Total Slider JS.