Create virtual algorithm class and concrete algorithm classes

TomographicImaging / CCPi-Regularisation-Toolkit

The set of CPU/GPU optimised regularisation modules for iterative image reconstruction and other image processing tasks

Apache License 2.0

49 stars 25 forks source link

Create virtual algorithm class and concrete algorithm classes #112

Open paskino opened 5 years ago

paskino commented 5 years ago

Currently the algorithms used in the toolkit are repeated within the different functions. This code repetition may lead to error.

Let's create an iterative algorithm class with the same structure of the Algorithm in the Framework.

dkazanc commented 5 years ago

I assume this means wrapping C/CUDA functions into C++ classes? Is it possible or one needs to change C syntax to C++ ?

paskino commented 5 years ago

possibly the largest change should be adding extern "C" to function definitions on the C++ code.

The main idea is to use the existing functions you developed in C/CUDA, not rewriting them. The object orientated structure should significantly reduce duplication of code.

dkazanc commented 5 years ago

makes sense. Happy to support this where I can.