search

TomographicImaging / CCPi-Regularisation-Toolkit

The set of CPU/GPU optimised regularisation modules for iterative image reconstruction and other image processing tasks
Apache License 2.0
49 stars 25 forks source link

NameError raised in tests is not caught, hence test crash if no GPU code is compiled #177

Closed paskino closed 5 months ago

paskino commented 1 year ago

These lines raise a NameError rather than ValueError. https://github.com/vais-ral/CCPi-Regularisation-Toolkit/blob/fc67dc0db27807d4964af7b83f8ce4460abd9324/test/test_run_test.py#L73

All tests crash, see for instance https://github.com/SyneRBI/SIRF-SuperBuild/actions/runs/5073437582/jobs/9112456133?pr=813#step:10:986

paskino commented 12 months ago

However these should be protected by https://github.com/vais-ral/CCPi-Regularisation-Toolkit/blob/fc67dc0db27807d4964af7b83f8ce4460abd9324/test/test_run_test.py#L7-L10

and the use of https://github.com/vais-ral/CCPi-Regularisation-Toolkit/blob/fc67dc0db27807d4964af7b83f8ce4460abd9324/test/test_run_test.py#L15