TomographicImaging / CIL-Demos

Apache License 2.0
20 stars 12 forks source link

Cil 24.2. iterative notebooks update #165

Closed MargaretDuff closed 3 weeks ago

MargaretDuff commented 2 months ago

Closes #134 - supersedes it

MargaretDuff commented 1 month ago

@lauramurgatroyd - the default step-size didn't change, instead how we implemented the Armijio rule. It shouldn't have broken backwards compatibility... and I think it is worth raising a separate issue in CIL but I haven't had chance to debug it yet. It will work if we change the Armijio rule parameters but this is too complicated for the first iterative notebook and instead I am considering maybe a notebook on step sizes and preconditioners for GD.

lauramurgatroyd commented 1 month ago

Okay, thanks. Yep I think we should investigate further

MargaretDuff commented 1 month ago

Let's merge it in one go - there are changes in 24.1 that break backwards compatibility so we should do all at once and update the install instructions at the same time

MargaretDuff commented 3 weeks ago

Have tested on 24.2 and all runs (although slowly so I would like to test again when the VM is free)

MargaretDuff commented 3 weeks ago

Have tested this morning and happy to merge!