CGLS cannot be imported with the latest master

TomographicImaging / CIL

A versatile python framework for tomographic imaging

https://tomographicimaging.github.io/CIL/

Apache License 2.0

97 stars 45 forks source link

CGLS cannot be imported with the latest master #117

Closed dkazanc closed 6 years ago

dkazanc commented 6 years ago

Strangely after compiling the master: ImportError: cannot import name 'CGLS' Others imported fine.

jakobsj commented 6 years ago

Strange, it works for me with the latest version. Could you give some more details, maybe a minimal example reproducing the error?

dkazanc commented 6 years ago

Have tried on 2 different machines. The same problem. Also function TV2D is not visible by the environment, so it makes CGLS and TV2D I do: cd Wrappers/Python conda build conda-recipe --numpy 1.12 --python 3.5 conda install ccpi-framework=0.9.2 --use-local --force

jakobsj commented 6 years ago

I still don't understand completely. Do you get an error during

conda build
conda install
or when trying to run some python code after successful build+install?

Can you run the demo_astra_simple in wip of the CCPi-astra, after build and install of that:

cd Wrappers/Python conda build conda-recipe --numpy 1.12 --python 3.5 -c astra-toolbox conda install ccpi-astra=0.9.3 --use-local --force

Also I notive you have 0.9.2. I believe it should be 0.9.3.

dkazanc commented 6 years ago

Didn't help to update to 0.9.3. The error when I'm importing the package, i.e. from ccpi.reconstruction.algs import CGLS I'll try running the astra-demo, thanks

jakobsj commented 6 years ago

You need ccpi.optimisation.algs instead

dkazanc commented 6 years ago

OK, some demos in wip comes with from ccpi.reconstruction.algs import FISTA, FBPD, CGLS

jakobsj commented 6 years ago

Sorry for the confusion, those are old and should have been removed as they are copied to other repos. One of the current PRs removes them.

The other PR fixes a bug with the TV2D so you may want to compare with that branch if implementing TV.

On Fri, 4 May 2018, 16:23 Daniil Kazantsev, notifications@github.com wrote:

OK, some demos in wip comes with from ccpi.reconstruction.algs import FISTA, FBPD, CGLS

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/vais-ral/CCPi-Framework/issues/117#issuecomment-386634535, or mute the thread https://github.com/notifications/unsubscribe-auth/AJg5CJVW5crI-6peVAdVewgKGedxgkwkks5tvHJugaJpZM4Tyit9 .

paskino commented 6 years ago

The code in wip is work-in-progress and may not work.

When opening an issue, please try to be a bit more descriptive. This message is not sufficient to understand what went wrong, and how to help.