Open epapoutsellis opened 2 years ago
check_convergence used in PDHG is not a clear name for its purpose. I suggest to rename to check_convergence_criterion and this convention can be used in every algorithm where a convergence criterion is known from theory. See ISTA/FISTA
check_convergence
check_convergence_criterion
What about is_convergent? I think this is clearer.
is_convergent
We need to replace check_convergenece in PDHG by provable_convergence_condition as agreed in the #1143 .
check_convergenece
check_convergence
used in PDHG is not a clear name for its purpose. I suggest to rename tocheck_convergence_criterion
and this convention can be used in every algorithm where a convergence criterion is known from theory. See ISTA/FISTA