search

TomographicImaging / CIL

A versatile python framework for tomographic imaging
https://tomographicimaging.github.io/CIL/
Apache License 2.0
93 stars 41 forks source link

PDHG check_convergence #1256

Open epapoutsellis opened 2 years ago

epapoutsellis commented 2 years ago

check_convergence used in PDHG is not a clear name for its purpose. I suggest to rename to check_convergence_criterion and this convention can be used in every algorithm where a convergence criterion is known from theory. See ISTA/FISTA

paskino commented 2 years ago

What about is_convergent? I think this is clearer.

epapoutsellis commented 2 years ago

We need to replace check_convergenece in PDHG by provable_convergence_condition as agreed in the #1143 .