TomographicImaging / CIL

A versatile python framework for tomographic imaging
https://tomographicimaging.github.io/CIL/
Apache License 2.0
94 stars 41 forks source link

Unittests for SPDHG take long time #1496

Open paskino opened 1 year ago

paskino commented 1 year ago

Unittests for SPDHG are done with the ASTRA cpu projector and on relatively large data, taking long time. We should reduce the amount of data that is processed.

https://github.com/TomographicImaging/CIL/blob/a2e45fe0aafe6329ec9027bda1cf262d4aff0284/Wrappers/Python/test/test_algorithms.py#L757-L770

gfardell commented 5 months ago

test_SPDHG_vs_PDHG_explicit and test_SPDHG_vs_PDHG_implicit are particularly slow. The assert_almost_equal on such a large array is probably one of the biggest costs.

MargaretDuff commented 5 months ago

Thanks Gemma - have added this comment to #1644 PR which attempted to fix the slow tests