Removed rtol and atol from GD so that it doesn't do early stopping automatically - Githubissues

TomographicImaging / CIL

A versatile python framework for tomographic imaging

https://tomographicimaging.github.io/CIL/

Apache License 2.0

97 stars 45 forks source link

Removed rtol and atol from GD so that it doesn't do early stopping automatically #1944

Open MargaretDuff opened 1 month ago

MargaretDuff commented 1 month ago

Changes

Testing you performed

Please add any demo scripts to https://github.com/TomographicImaging/CIL-Demos/tree/main/misc

Related issues/links

Closes #1942

Checklist

[x] I have performed a self-review of my code
[x] I have added docstrings in line with the guidance in the developer guide
[x] I have updated the relevant documentation
[x] I have implemented unit tests that cover any new or modified functionality
[ ] CHANGELOG.md has been updated with any functionality change
[x] Request review from all relevant developers
[ ] Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

[x] The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License
[x] I confirm that the contribution does not violate any intellectual property rights of third parties

MargaretDuff commented 1 month ago

Can we also remove repeats

MargaretDuff commented 1 month ago

Not true for GD