search

TomographicImaging / CIL

A versatile python framework for tomographic imaging
https://tomographicimaging.github.io/CIL/
Apache License 2.0
98 stars 45 forks source link

Check convergence in PDHG throws an error, and should be False by default #1965

Open MargaretDuff opened 1 month ago

MargaretDuff commented 1 month ago

Description

The continued mission to kill kwargs... we should delete these line: https://github.com/TomographicImaging/CIL/blob/23187c9eebfc691a4d65178c37a6cf59b01a0d57/Wrappers/Python/cil/optimisation/algorithms/PDHG.py#L320C7-L321C37

lauramurgatroyd commented 1 month ago

check_convergence currently isn't usable because: https://github.com/TomographicImaging/CIL/blob/23187c9eebfc691a4d65178c37a6cf59b01a0d57/Wrappers/Python/cil/optimisation/algorithms/PDHG.py#L225 passes it to the Algorithm base class which throws an error: Algorithm.init() got an unexpected keyword argument 'check_convergence'