search

TomographicImaging / CIL

A versatile python framework for tomographic imaging
https://tomographicimaging.github.io/CIL/
Apache License 2.0
98 stars 45 forks source link

Identity Operator - Domain and Range geometry should be the same #1980

Open MargaretDuff opened 2 weeks ago

MargaretDuff commented 2 weeks ago

Description

In the Identity Operator, domain and range geometry can be set to be different: https://github.com/TomographicImaging/CIL/blob/5d569dc054759a8c137ca72611fc7be07be6080e/Wrappers/Python/cil/optimisation/operators/IdentityOperator.py#L40-L47

However, the forward and adjoint operators just return their input. They do not use the range geometry:

https://github.com/TomographicImaging/CIL/blob/5d569dc054759a8c137ca72611fc7be07be6080e/Wrappers/Python/cil/optimisation/operators/IdentityOperator.py#L49-L71

Propose that the option to pass a range geometry is removed.

Discussed with @bosschmidt at the CIL user meeting hackathon.