TomographicImaging / CIL

A versatile python framework for tomographic imaging
https://tomographicimaging.github.io/CIL/
Apache License 2.0
98 stars 45 forks source link

`AcquisitionType` enum not backward compatible #1995

Open DanicaSTFC opened 6 days ago

DanicaSTFC commented 6 days ago

Description

The edited class AcquisitionType in v24.2.0 has geom_type in capital letters. This is not backward compatible with the previous versions of CIL, where the options were 'cone' and 'parallel'. Also, the type is no longer a string and users might have used string methods in their code. e.g. lower()

https://github.com/TomographicImaging/CIL/blob/5d569dc054759a8c137ca72611fc7be07be6080e/Wrappers/Python/cil/framework/labels.py#L240-L241

This created a problem in the CIL-GUI: see https://github.com/TomographicImaging/CIL-GUI/pull/283

I have now fixed the problem for the CIL-GUI but I wanted to flag this as it might affect other users.

Environment

New environment for CIL v24.2.0