TomographicImaging / CIL

A versatile python framework for tomographic imaging
https://tomographicimaging.github.io/CIL/
Apache License 2.0
97 stars 44 forks source link

Algorithms to create x_init automatically to the zero image #382

Closed paskino closed 2 years ago

paskino commented 5 years ago

Could we have a default x_init automatically set to the zero image of appropriate size? We almost always use that and would save the user from worrying about allocating one. Of course should allow to pass an x_init if desired.

paskino commented 5 years ago

BTW functions do not have a domain defined? @jakobsj @epapoutsellis

In FISTA we only pass functions so it's not possible at the moment to know what is the domain and hence to create the right initialisation data container

jakobsj commented 5 years ago

I've been thinking about the same thing, really algorithms only deal with functions so would need to check function domain. Maybe leave as is for now and think about it whether we want function domains

On Fri, 11 Oct 2019, 20:43 Edoardo Pasca, notifications@github.com wrote:

BTW functions do not have a domain defined?

In FISTA we only pass functions so it's not possible at the moment to know what is the domain and hence to create the right initialisation data container

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vais-ral/CCPi-Framework/issues/382?email_source=notifications&email_token=ACMDSCGFH6N4DAA3GSSWQILQODJOVA5CNFSM4I73PHN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBBAVTQ#issuecomment-541199054, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACMDSCG2Z6DQCQKDUY7XZJDQODJOVANCNFSM4I73PHNQ .

epapoutsellis commented 5 years ago

it is my fault, it can be done but we need to change many files.

paskino commented 5 years ago

it seems that this requires a bit more thought. I'll take this issue off the symposium milestone.

paskino commented 4 years ago

see #520