search

TomographicImaging / CILViewer

A simple Viewer for 3D data built with VTK
Apache License 2.0
8 stars 6 forks source link

When conda building, get "Built wheel for ccpi-viewer is invalid" error #333

Closed lauramurgatroyd closed 1 year ago

lauramurgatroyd commented 1 year ago

When we run actions we consistently get this: https://github.com/vais-ral/CILViewer/actions/runs/3524392336/jobs/5909735176#step:4:587

WARNING: Built wheel for ccpi-viewer is invalid: Metadata 1.2 mandates PEP 440 version, but '22.4.0-26-gd763c8c' is not DEPRECATION: ccpi-viewer was installed using the legacy 'setup.py install' method, because a wheel could not be built for it. pip 23.1 will enforce this behaviour change. A possible replacement is to fix the wheel build issue reported above. Discussion can be found at https://github.com/pypa/pip/issues/8368

I believe we need to move this line: https://github.com/vais-ral/CILViewer/blob/9ebd5ea3246007e1267cf9298f61a75ea3c73304/Wrappers/Python/setup.py#L48 out of the if statement so that we are always converting the version to pep440 compatible. Currently it only happens if we aren't conda building.

What was the original reason behind only converting this if we aren't conda building?