TomographicImaging / CILViewer

A simple Viewer for 3D data built with VTK
Apache License 2.0
8 stars 6 forks source link

If we add a widget with the same name as an existing widget, what should happen to the existing widget? #342

Closed lauramurgatroyd closed 1 year ago

lauramurgatroyd commented 1 year ago

Currently it continues to exist but there is no reference to it in the dictionary of widgets.

We should either throw an error saying that the widget already exists, or we should delete the existing widget with that name.

https://github.com/vais-ral/CILViewer/blob/28591187707b1a80ebbd3224abec86fc09ebe4ad/Wrappers/Python/ccpi/viewer/CILViewerBase.py#L365-L367

paskino commented 1 year ago

I think it should throw an error.

lauramurgatroyd commented 1 year ago

Closed by #343