Raw input preview - Githubissues

paskino commented 11 months ago

Should close #383

This PR did not pass the tests. Part of the work has been used in a new PR #410.

Adds preview button to the raw input dialog.
hides slider in the preview dialog (see https://github.com/vais-ral/CILViewer/issues/384)
hides one of the axes in 2D viewer preview (merged #408)
[ ] Tested on knee data and not working. A working version has been found in another branch after removing the fortran ordering. (@paskino)
[ ] add unit tests (or not?)
[ ] run unit tests. At the moment many are failing (@paskino)

Not to be done in this PR:

test the code for dimensionality = 2. Opened https://github.com/TomographicImaging/CILViewer/issues/404
test on web viewer, opened #400
Remove fortran ordering from the raw input dialog (see https://github.com/vais-ral/CILViewer/issues/390)

paskino commented 9 months ago

This worked great with the 16bit dataset that I tried, but I had problems with an 8bit dataset... The preview cut the slice in half:

But when pressing 'OK' with those same settings, it loaded fine:

Could you share the dataset?

DanicaSTFC commented 4 months ago

This is a great added feature!

DanicaSTFC commented 2 months ago

This worked great with the 16bit dataset that I tried, but I had problems with an 8bit dataset... The preview cut the slice in half: But when pressing 'OK' with those same settings, it loaded fine:

Could you share the dataset?

Data has been shared in Tomography-Data, DVC

The "file 40891_8bit_1431-1260-1335" is not uploaded correctly with the settings indicated by @lauramurgatroyd

By editing the fortran ordering the image is uploaded correctly, this work is currently stored in another branch

paskino commented 1 month ago

Probably we should rename Size XYZ to height width and number of images as done in ImageJ This would render the Fortran thing useless.

DanicaSTFC commented 1 month ago

Probably we should rename Size XYZ to height width and number of images as done in ImageJ This would render the Fortran thing useless.

If we do so we should add an option in the app where the user can rename the labels eg. when saving images for research papers and investigating their system

paskino commented 1 month ago

If we do so we should add an option in the app where the user can rename the labels eg. when saving images for research papers and investigating their system

Yes, but that would be and advanced feature. So far I'd be happy if the dialog required the appropriate information and used it well. The axis labels defaults could, on first instance, remain X,Y and Z.

paskino commented 1 month ago

The probable culprit of the failing unit tests is the change in the conversion.py

DanicaSTFC commented 1 month ago

If we do so we should add an option in the app where the user can rename the labels eg. when saving images for research papers and investigating their system

Yes, but that would be and advanced feature. So far I'd be happy if the dialog required the appropriate information and used it well. The axis labels defaults could, on first instance, remain X,Y and Z.

I opened a new issue for this https://github.com/TomographicImaging/CILViewer/issues/406. The topic should be addressed in #390 as we will not address this here. I opened a new issue https://github.com/TomographicImaging/CILViewer/issues/407 for the advanced feature

DanicaSTFC commented 1 month ago

Closed as superseded by #410

TomographicImaging / CILViewer

Raw input preview #356