Fix failing unit tests - Githubissues

TomographicImaging / eqt

A number of templates and tools to develop Qt GUI's with Python effectively.

Other

2 stars 3 forks source link

Fix failing unit tests #106

Closed lauramurgatroyd closed 8 months ago

lauramurgatroyd commented 8 months ago

Closes #78

I had to move the TestMainWindowWithSessionManagementCreateLoadSessionDialog test into a separate file: test\test_MainWindowWithSessionManagementDialogs.py because this needed to test elements of LoadSessionDialog whose import had been mocked elsewhere in the test\test_MainWindowWithSessionManagement.py file for other tests.
In one test there was a dialog which was opened and blocked the other tests from running until we physically closed the dialog. I prevented this by using dialog.open() instead of dialog._exec()
Fixed a failing unit test due to incorrect whitespace in a string.

lauramurgatroyd commented 8 months ago

Should we change the open and close form situation in this same PR?

Sorry what do you mean by this?

DanicaSTFC commented 8 months ago

Should we change the open and close form situation in this same PR?

Sorry what do you mean by this?

I mean that when we run the tests the forms are opening and closing quickly, and we discussed (in private) to change this so the forms are not opened in the tests at all. I was thinking this PR is a good place to fix this unless we want to open a new issue for it.

lauramurgatroyd commented 8 months ago

We should open a new issue for it, this PR is just addressing failing unit tests

DanicaSTFC commented 8 months ago

We should open a new issue for it, this PR is just addressing failing unit tests

I opened a new issue for this https://github.com/TomographicImaging/eqt/issues/110#issue-2009626637

lauramurgatroyd commented 8 months ago

Thanks!