search

TomographicImaging / eqt

A number of templates and tools to develop Qt GUI's with Python effectively.
Other
2 stars 3 forks source link

Pip action fails #37

Closed paskino closed 2 years ago

paskino commented 2 years ago

On the latest tag the action creating the pip package has failed https://github.com/paskino/qt-elements/actions/runs/1394915075

paskino commented 2 years ago

This seems to have evaluated to false

lauramurgatroyd commented 2 years ago

Was it definitely an annotated tag?

lauramurgatroyd commented 2 years ago

I see that the conda action also did not upload as it thought there was no annotated tag.

https://github.com/paskino/qt-elements/runs/4035466476?check_suite_focus=true

lauramurgatroyd commented 2 years ago

The conda one doesn't fail as it has an option to not upload, which we use unless we're tagging.

lauramurgatroyd commented 2 years ago

For it to upload the packages, an annotated tag has to be made, then the action is triggered by the tag. E.g. you see the tag name next to the run.

image

lauramurgatroyd commented 2 years ago

When we make a release it doesn't have the same behaviour which I think is what happened here:

image

lauramurgatroyd commented 2 years ago

I made a new annotated tag and it triggered the actions to publish to pypi and conda, which worked.

I found there are 2 actions trying to publish to pypi, one triggered by tagging and one triggered by release. We do not need both. I will delete the one being triggered on release which we do not use.