better pre-commit config

[DanicaSTFC]

Pre-commit on GitHub checks the code and commits automatically part of the suggested changes. It leaves some suggestions unsolved with the red cross appearing and stopping the merge. It would be easier if we could run the checker online, receive a report from it and then decide to accept or reject the changes and fix some things manually. There are some issues, in particular, with long lines of code and alignment of # comments. The suggested edits and indentations do not look good.

I started to use the pre-commit offline in my local repository and it works well because the suggestions are not forced in a commit and I can amend them.

[lauramurgatroyd]

Please can you link some examples where it does not look good?

[casperdcl]

btw https://github.com/google/yapf/#knobs <- config options for https://github.com/TomographicImaging/eqt/blob/main/pyproject.toml

[DanicaSTFC]

[like] Sugic, Danica (STFC,RAL,SC) reacted to your message:

---

From: Casper da Costa-Luis @.> Sent: Wednesday, November 29, 2023 10:20:17 AM To: TomographicImaging/eqt @.> Cc: Sugic, Danica (STFC,RAL,SC) @.>; Author @.> Subject: Re: [TomographicImaging/eqt] Pre-commit forces commit on partial suggestions only (Issue #98)

btw https://github.com/google/yapf/#knobs <- config options for https://github.com/TomographicImaging/eqt/blob/main/pyproject.toml

— Reply to this email directly, view it on GitHubhttps://github.com/TomographicImaging/eqt/issues/98#issuecomment-1831609279, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BBBNSBUNU37TISURBTD35RDYG4D6DAVCNFSM6AAAAAA6XYSK42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZRGYYDSMRXHE. You are receiving this because you authored the thread.Message ID: @.***>

[DanicaSTFC]

@casperdcl pointed out this is high priority for other repositories too, finalise before end of June 2024

[DanicaSTFC]

List of hooks and id:

https://github.com/pre-commit/pre-commit-hooks/blob/0c625349aa4def4cc52fc560f7a94311b8be0607/.pre-commit-hooks.yaml#L67