Closed yw-fang closed 2 years ago
@yw-fang
Thank you for the tip.
I'll modify the following a bit more
tmp_info = pd.Series([9999, 50, 9999, 9999, 9999, 9999, 9999,'equal', 'TNM'], index=ea_info.columns)
ea_info = pd.concat([ea_info, pd.DataFrame(tmp_info).T], axis=0, ignore_index=True)
like this:
tmp_info = pd.DataFrame([[9999, 50, 9999, 9999, 9999, 9999, 9999,'equal', 'TNM']], columns=ea_info.columns)
ea_info = pd.concat([ea_info, tmp_info], axis=0, ignore_index=True)
I will skip to merge because there are other corrections in addition to ea_next_gen.py, and reflect the fix in the next version.
Sure! No problem to skip it. Your revision is cleaner than mine if tmp_info is defined as a dataframe at first. Since you have noticed this issue, II'll close this pull request here. Thanks!
Hi, Yamashita-san
I noticed the warning "FutureWarning: The frame.append method is deprecated and will be removed from pandas in a future version." these days when I used the latest two versions of CrySPY to generate the structures in the next generation. I employed "concat" method instead of the "append" method for your consideration. A demo example is shown below to compare the two methods.
Best wishes Yuewen Fang
The "append" method in CrySPY
The output is
The "contact" method in CrySPY
The output is