Tomsz24 / mentoring-todo

0 stars 0 forks source link

Add husky and prettier #1

Open olvnikon opened 1 year ago

olvnikon commented 1 year ago

Let's install husky and prettier as dev dependencies. If you have any issues with the latest husky, you may install an older version as it was simpler.

https://github.com/Tomsz24/mentoring-todo/blob/e7d30a1d0c47b7d5f81de50d29b50f91c325f321/package.json#L38

Tomsz24 commented 1 year ago

It's done but I forget to create separate branch for this to make it properly 😞😭 But husky, prettier and aslant are implemented together with lint-staged 😉 What do you think about this config @olvnikon ? Did I missed something?🤔

olvnikon commented 1 year ago

It's done but I forget to create separate branch for this to make it properly 😞😭 But husky, prettier and aslant are implemented together with lint-staged 😉 What do you think about this config @olvnikon ? Did I missed something?🤔

You also may add eslint to lint staged

  "lint-staged": {
    "*.{js,jsx,ts,tsx,md,html,css}": ["prettier --write", "eslint --fix"]
  },

Additionally, you need to install an eslint plugin for prettier. Otherwise, they may conflict.

Tomsz24 commented 1 year ago

I will take a look with next commit 😃

olvnikon commented 1 year ago

I will take a look with next commit 😃

Please, let's create pull requests 🙏 It is very difficult to review code base

Tomsz24 commented 1 year ago

This time I will not forget 😂