search

ToneDen / Player

A pure JS customizable audio player for SoundCloud.
toneden.io/player
MIT License
529 stars 77 forks source link

Player crashes when given a link to a playlist #52

Closed giubil closed 8 years ago

giubil commented 8 years ago

Hello, I don't know if this is voluntary or not, but when feeding the player an url in the form:

https://soundcloud.com/*/sets/*

it fails to load.

mercuree commented 8 years ago

@giubil Try this patch https://github.com/ToneDen/toneden-sdk/pull/51

thathurtabit commented 8 years ago

I have the same issue. Can't get a 'set' to load, but the url should be 'SETS' https://soundcloud.com/nonbeliever/SETS/a-model-of-modern-influence not 'set' or 'playlist'.

Unless the SDK thinks playlists are sets, I'm not sure: https://github.com/dreamdt/toneden-sdk/commit/ea65a634d21625e30f00e191689ceacb2a254818

mercuree commented 8 years ago

@thathurtabit

the url should be 'SETS'

You are right, but this code is not about url, it's about response: soundcloud response object

thathurtabit commented 8 years ago

@dreamdt Ah. I see. So your solution seems to fix the problem then? Is there a way I can link to your updated version, or do we need to wait until it's merged into https://github.com/ToneDen/toneden-sdk ? Apologies for my cluelessness.

mercuree commented 8 years ago
  1. Yes, it works for me, but you should use "/sets/" inside url (not /SETS/)
  2. Inside toneden.loader.js, you should replace "//sd.toneden.io/production/v2/" with your own domain and path. I think it will be enough (if not, it would be better to wait until merge) https://github.com/dreamdt/toneden-sdk/releases/download/v2.0/toneden-sdk.zip
thathurtabit commented 8 years ago

Huzzah @dreamdt! It works! Thank you for your help. Hopefully your fix should get merged soon.

elsbree commented 8 years ago

Thanks for fixing this. I just merged the PR by @dreamdt and deployed it to our CDN.