search

Tonejs / Midi

Convert MIDI into Tone.js-friendly JSON
http://tonejs.github.io/Midi/
MIT License
885 stars 117 forks source link

Applying pitch bends as part of fromJSON #175

Closed colinfwren closed 1 year ago

colinfwren commented 1 year ago

Thanks so much for writing this wrapper over midi-file, it's been really useful in my project - midi-to-lsdj.

I noticed that when calling fromJSON (which I use a lot to set up a test MIDI objects) that pitch bends weren't being applied if they were part of that JSON representation.

I've added this to the fromJSON method in Track but I wasn't sure if I should add a pitch bend event to the bach_846.json file used in the tests or not to verify the behaviour.

tambien commented 1 year ago

thanks!