Closed liJie-wk closed 2 years ago
thanks for the suggestion, do you know if this sort of thing counts?
if not, then i think all of the try/catch blocks take the e
parameter (just did a quick search on the codebase).
I'm sorry, but I don't quite understand what you mean. Its error message goes like this.
I changed all the try catches to this and that's fine
@tambien
It's not in the Tone.js codebase, so it might be within a Tone.js dependency like standardized-audio-context.
@chrisguttandin does this code look familiar to you?
Yes, this looks very familiar. I'm pretty sure it's coming from here: https://github.com/chrisguttandin/standardized-audio-context/blob/b1e93e093c57b247ce78c281854681de959b38a6/src/helpers/is-constructible.ts#L15.
Am I correct that standardized-audio-context gets bundled with Tone.js? I thought so, since the file shown in the screenshots above is named Tone.js
. Maybe it's an option to transpile standardized-audio-context before it gets bundled.
I'm trying to publish standardized-audio-context in a recent version of the EcmaScript spec. Right now it's ES2019. My reasoning behind this was that transpiling down from ES2019 to -for example- ES2015 is always possible whereas the opposite is a challenge.
However I also want to change the way I publish packages once more to use the new exports property. But I'm not sure when I will have time to finally do that. Maybe this allows to publish different EcmaScript versions simultaneously.
Older versions of android-system-webview aOlder versions of android-system-webview are not supported by some syntaxre not supported by some syntax
try{}catch{} , There is a compatibility issue.
Change to try{}catch(e) {} and solve it