search

Tonejs / Tone.js

A Web Audio framework for making interactive music in the browser.
https://tonejs.github.io
MIT License
13.37k stars 976 forks source link

Transport.progress: docs typo fix #1120

Closed satelllte closed 1 year ago

satelllte commented 1 year ago

Makes the description cleaner. Docs reference: https://tonejs.github.io/docs/14.7.77/Transport#progress

Thanks!

CI issue

The issue https://github.com/Tonejs/Tone.js/issues/1123 still stays after 5 CI retries. I think it'll pass sooner or later eventually so I just marked this PR as ready for review

codecov[bot] commented 1 year ago

Codecov Report

Merging #1120 (a59a05b) into dev (ae0033d) will decrease coverage by 0.03%. The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1120      +/-   ##
==========================================
- Coverage   98.43%   98.40%   -0.03%     
==========================================
  Files         184      184              
  Lines        7710     7710              
  Branches      679      679              
==========================================
- Hits         7589     7587       -2     
- Misses         34       35       +1     
- Partials       87       88       +1
Impacted Files Coverage Δ
Tone/core/clock/Transport.ts 98.37% <ø> (ø)
Tone/event/PatternGenerator.ts 97.18% <0.00%> (-2.82%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

tambien commented 1 year ago

Thanks @satelllte! One simple solution is to also change the codecov failure criteria to have a slightly higher threshold for failure.