search

Tonejs / Tone.js

A Web Audio framework for making interactive music in the browser.
https://tonejs.github.io
MIT License
13.37k stars 976 forks source link

[CI] Codecov report for `PatternGenerator.ts` file is not deterministic #1123

Closed satelllte closed 4 months ago

satelllte commented 1 year ago

Please note

The bug is not related to the library itself, but rather the tests / CI.

Describe the bug

Just opened 3 pull requests with documentation updates, but the code coverage report of PatternGenerator.ts was not deterministic.

Failed code coverage report reference: https://app.codecov.io/gh/Tonejs/Tone.js/pull/1120

In these 2 pull requests it failed:

This pull request passed:

image

Expected behavior

Code coverage CI tests must be deterministic.

satelllte commented 1 year ago

The problem can only be fixed on re-triggering the CI run, for example pushing the empty commit made via git commit -m 'trigger CI' --allow-empty. For reference: https://github.com/Tonejs/Tone.js/pull/1121

tambien commented 4 months ago

yeah i've noticed that too. probably because there is some randomness in one of the pattern types. I've updated the codecov config to not throw an error when the coverage value changes so slightly