Closed marcelblum closed 4 months ago
Attention: Patch coverage is 50.00000%
with 1 lines
in your changes are missing coverage. Please review.
:exclamation: No coverage uploaded for pull request base (
dev@56fea7c
). Click here to learn what that means.:exclamation: Current head 843870c differs from pull request most recent head fbd1135. Consider uploading reports for the commit fbd1135 to get more accurate results
Files | Patch % | Lines |
---|---|---|
Tone/core/context/AudioContext.ts | 50.00% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Dang I wasn't seeing those tests fail locally, will investigate soon.
🙏🏻 @marcelblum and @chrisguttandin
This is a fix for the following bug which occurs when trying to instantiate any effect node that uses an AudioWorklet (BitCrusher, JCReverb, etc.) if using Tone with a native context (non-Standardized Audio Context):
If there's any better way than this to check if a context is from Standardized Audio Context or not, let me know! ~~This is using
context.constructor.name.includes("AudioContext")
which catches native online & offline contexts consistently AFAICT, whereas with those created by Standardized Audio Contextcontext.constructor.name
is always an empty string.~~ Now usingcontext instanceof window.BaseAudioContext
per @chrisguttandin's suggestion.