search

Tonejs / Tone.js

A Web Audio framework for making interactive music in the browser.
https://tonejs.github.io
MIT License
13.37k stars 976 forks source link

Tone.Loop Constructor does not set humanize #1149

Closed nmarshall23 closed 1 year ago

nmarshall23 commented 1 year ago

Describe the bug

Tone.Loop does not set humanize option when using the options Constructor.

On line 55 When creating a ToneEvent it should set humanize.

To Reproduce

const loop = new Tone.Loop({
    callback: (time) => console.log(time),
    interval: 4,
    humanize: 16,
}).start(0);
console.log(loop.humanize) // this is false
Tone.Transport.start();
pritam-chowdhury commented 1 year ago

@tambien @nmarshall23 I have raised a pull request((1154) for the issue . can you please have a look and revert back to it Thanks :)

tambien commented 1 year ago

fixed by #1154