search

Tonejs / Tone.js

A Web Audio framework for making interactive music in the browser.
https://tonejs.github.io
MIT License
13.24k stars 963 forks source link

EQ3 colors even when all gains are set to 0. #1218

Closed BarnabasSzabolcs closed 2 months ago

BarnabasSzabolcs commented 7 months ago

Describe the bug

EQ3 takes away mid frequencies even with 0 gain on all channels.

To Reproduce

I run the following chain: Tone.Player( with my mp3) -> Tone.EQ3 -> output. If I just put Tone.Player( with my mp3) -> output, it sounds different, even though the EQ3 is set to 0 gain on all channels.

const eq = new Tone.EQ3({
  high: 0,
  mid: 0,
  low: 0,
  lowFrequency: 300,
  highFrequency: 600,
});
eq.toDestination();
const player = new Tone.Player(audioFile).connect(eq);

Expected behavior A description of what you expected to happen.

What I've tried I'll probably try and write a parametric eq.

Additional context I wanted to create a parametric eq by serially chaining EQ3-s.

tambien commented 2 months ago

EQ high/mid/low values are all in Decibels, so 0 would mean no change. -Infinity should silence all of those bins.

BarnabasSzabolcs commented 1 month ago

Well, that is why it was a bug on Nov 26, 2023, @tambien because I observed change in the tone. If you have fixed it then it is fixed. I ended up taking rather the AI suggestion and built the plugin by probably chaining filters or so, because I wanted a few more channels in my eq.