search

Tonejs / Tone.js

A Web Audio framework for making interactive music in the browser.
https://tonejs.github.io
MIT License
13.41k stars 976 forks source link

Channel doesn't work correctly with schedule Patterns ! #927

Open shahramSo opened 3 years ago

shahramSo commented 3 years ago

I have created a sample to show that how the schedule pattern for sequencer work with channel component. But Solo and some times mute doesn't work correctly, for example when I select solo for a player other players do not become mute. Please check this sample and select a solo Checkbox for a player and false , true it consecutively then you will hear that the other players still work. the sample link as follows: https://codesandbox.io/s/test-of-schedulepattern-4t0pk?file=/src/index.ts:810-824

I don't know this implementation of channel for a multi players is correct or not. Thanks

tambien commented 3 years ago

When i'm playing around with your code it is working as expected for me. but maybe i'm not understanding what the issue is.

Here is what i'm doing and hearing:

1) Start the beat, Hear kick + snare + hihat 2) Hit the first 'solo' button. Hear the solo'ed kick drum 3) Hit the second 'solo' button. Hear the solo'ed kick + snare 4) Uncheck the first and second checkboxes, hear all three parts again.

shahramSo commented 3 years ago

Hi, thank you for your reply, In my side and on my test sometimes solo doesn't work correctly, please test a solo for example only for hihat so you will hear other instruments like snare or kick. If you try it several times, you will notice other is playing.

shahramSo commented 3 years ago

@tambien, I made a video for you in which I showed that solo does not work well Please be careful when hearing sounds when I check it. And also when I turn the mouse it is the moment when other sounds do not work properly.

https://user-images.githubusercontent.com/22150939/129755605-06fe50da-8a40-4500-9efd-d722d58ebd3e.mp4