Tonexus / poe-scambot

A tool meant to quickly and efficiently search for items in Path of Exile via the stash tab API.
43 stars 8 forks source link

tkinter window closing #7

Open repmop opened 7 years ago

repmop commented 7 years ago

Your app kill function in the main scipt crashes out on my setup, I fixed this by commenting out the loop that tries to kill each thread and changing self.kill to self.destroy.

MortimerMcMire commented 7 years ago

That only happens if you run it through idle. Idle uses sockthread which doesn't have a kill function. Running through python not idle works fine

repmop commented 7 years ago

Gotcha thanks, I only ran it through idle because the main script didn't seem to launch correctly through cmd (maybe I'm just doing something wrong on my end, not sure).

Tonexus commented 7 years ago

You shouldn't even need to use cmd, just double click on the script. If you do want to use cmd, you can run python scambot.pyw or I'm pretty sure just scambot.pyw works as well. I'll work on trying to fix the IDLE crash though.

repmop commented 7 years ago

again, both cmd and executing like normal have no effect, leaving me only to launch via idle :(

Tonexus commented 7 years ago

Not even any error messages?

repmop commented 7 years ago

nope, just nothing happening

Tonexus commented 7 years ago

Are you using python 3.4? Do you have a separate python 2.x installed? Can you try adding a print statement after if __name__ == '__main__': and see if it runs? If it doesn't work, try adding a print statement at the very beginning of the file.

repmop commented 7 years ago

Python 3.5.2 and yes I do have a separate python2 install iirc. Print statements added, still nothing going on there (works normally through IDLE).

Tonexus commented 7 years ago

Neither of the print statements work? Try using python3 scambot.pyw to confirm that you aren't defaulting to python 2. If the print statement before the imports doesn't work, there might be something wrong with your python installation, and maybe you should try reinstalling? Does the same behavior occur for other python 3 scripts?

repmop commented 7 years ago

It seems something weird is going on with my how my system configuration recognizes .pyw files, since manually using python scambot.pyw in cmd like you suggested works fine (this rules out a python2 default as well). You might want to add a section talking about how to run the script through an editor as well, since that at least works for me at the moment, and is likely more convenient than running through cmd. Thanks so much for your help!