Toni-SM / skrl

Modular reinforcement learning library (on PyTorch and JAX) with support for NVIDIA Isaac Gym, Omniverse Isaac Gym and Isaac Lab
https://skrl.readthedocs.io/
MIT License
443 stars 43 forks source link

return render frames from gymnasium render function #68

Closed m-m-adams closed 11 months ago

m-m-adams commented 1 year ago

The gymnasium render function returns frames in RGB array mode. This commit just passes through the return of the gymnasium render

This is useful for saving animations for demonstrations

Toni-SM commented 1 year ago

Hi @m-m-adams

Can you please make a clean pull request only with the change to return the values depending on the selected display mode. There are many changes in the file related to formatting / code style that are not related to the implemented feature.

Toni-SM commented 11 months ago

Hi @m-m-adams

Due to the features introduced in what will be version 1.0.0-preview.1 there are the following elements:


Then, to also cover the gymnasium wrapper for JAX, please, open a new pull-request on the develop branch and update the following files:

Also, please, follow the commit convention described in CONTRIBUTING.md (in particular the first subpoint):

https://github.com/Toni-SM/skrl/blob/6b8b70fc2f5fd13087c70a9b51f0ef630c638bcc/CONTRIBUTING.md?plain=1#L48-L51

I am going to close this pull request Waiting for the new pull-request... :)