ToniA / arduino-heatpumpir

An Arduino library to control split-unit heatpumps over Infrared
GNU General Public License v2.0
389 stars 140 forks source link

Compilation fails on ESP-IDF5.3/Arduino 3.0.4 #181

Open TD-er opened 3 weeks ago

TD-er commented 3 weeks ago

I'm currently implementing support in ESPEasy for ESP-IDF5.3/Arduino 3.0.4

The compiler gives warnings on this library code which are considered breaking errors and thus failed builds.

In file included from lib/HeatpumpIR/AUXHeatpumpIR.h:7,
                 from lib/HeatpumpIR/HeatpumpIRFactory.h:4,
                 from /home/gijs/GitHub/TD-er/ESPEasy/src/_P088_HeatpumpIR.ino:47:
lib/HeatpumpIR/HeatpumpIR.h:66:18: warning: 'virtual void HeatpumpIR::send(IRSender&, uint8_t)' was hidden [-Woverloaded-virtual=]
   66 |     virtual void send(IRSender& IR, uint8_t currentTemperature);
      |                  ^~~~
In file included from lib/HeatpumpIR/HeatpumpIRFactory.h:11:
lib/HeatpumpIR/DaikinHeatpumpARC480A14IR.h:52:10: note:   by 'DaikinHeatpumpARC480A14IR::send'
   52 |     void send(IRSender& IR, uint8_t powerModeCmd, uint8_t operatingModeCmd, uint8_t fanSpeedCmd, uint8_t temperatureCmd, uint8_t swingVCmd, uint8_t swingHCmd, uint8_t comfortMode, uint8_t econo, uint8_t sensor, uint8_t quiet, uint8_t powerful);
      |          ^~~~
lib/HeatpumpIR/HeatpumpIR.h:66:18: warning: 'virtual void HeatpumpIR::send(IRSender&, uint8_t)' was hidden [-Woverloaded-virtual=]
   66 |     virtual void send(IRSender& IR, uint8_t currentTemperature);
      |                  ^~~~
In file included from lib/HeatpumpIR/HeatpumpIRFactory.h:14:
lib/HeatpumpIR/FujitsuHeatpumpIR.h:43:10: note:   by 'FujitsuHeatpumpIR::send'
   43 |     void send(IRSender& IR, uint8_t powerModeCmd, uint8_t operatingModeCmd, uint8_t fanSpeedCmd, uint8_t temperatureCmd, uint8_t swingVCmd, uint8_t swingHCmd, bool ecoModeCmd);
      |          ^~~~
lib/HeatpumpIR/HeatpumpIR.h:66:18: warning: 'virtual void HeatpumpIR::send(IRSender&, uint8_t)' was hidden [-Woverloaded-virtual=]
   66 |     virtual void send(IRSender& IR, uint8_t currentTemperature);
      |                  ^~~~
In file included from lib/HeatpumpIR/HeatpumpIRFactory.h:15:
lib/HeatpumpIR/GreeHeatpumpIR.h:121:18: note:   by 'GreeHeatpumpIR::send'
  121 |     virtual void send(
      |                  ^~~~
lib/HeatpumpIR/HeatpumpIR.h:66:18: warning: 'virtual void HeatpumpIR::send(IRSender&, uint8_t)' was hidden [-Woverloaded-virtual=]
   66 |     virtual void send(IRSender& IR, uint8_t currentTemperature);
      |                  ^~~~
In file included from lib/HeatpumpIR/HeatpumpIRFactory.h:24:
lib/HeatpumpIR/MitsubishiHeavyHeatpumpIR.h:128:18: note:   by 'MitsubishiHeavyHeatpumpIR::send'
  128 |     virtual void send(IRSender& IR, uint8_t powerModeCmd, uint8_t operatingModeCmd, uint8_t fanSpeedCmd, uint8_t temperatureCmd, uint8_t swingVCmd, uint8_t swingHCmd, bool cleanModeCmd, bool silentModeCmd, bool _3DAutoCmd);
      |                  ^~~~
lib/HeatpumpIR/HeatpumpIR.h:66:18: warning: 'virtual void HeatpumpIR::send(IRSender&, uint8_t)' was hidden [-Woverloaded-virtual=]
   66 |     virtual void send(IRSender& IR, uint8_t currentTemperature);
      |                  ^~~~
In file included from lib/HeatpumpIR/HeatpumpIRFactory.h:27:
lib/HeatpumpIR/PanasonicAltDKEHeatpumpIR.h:60:10: note:   by 'PanasonicAltDKEHeatpumpIR::send'
   60 |     void send(IRSender& IR, bool quiet, bool powerful);
      |          ^~~~
lib/HeatpumpIR/HeatpumpIR.h:66:18: warning: 'virtual void HeatpumpIR::send(IRSender&, uint8_t)' was hidden [-Woverloaded-virtual=]
   66 |     virtual void send(IRSender& IR, uint8_t currentTemperature);
      |                  ^~~~
In file included from lib/HeatpumpIR/HeatpumpIRFactory.h:29:
lib/HeatpumpIR/PanasonicHeatpumpIR.h:63:10: note:   by 'PanasonicHeatpumpIR::send'
   63 |     void send(IRSender& IR, uint8_t powerModeCmd, uint8_t operatingModeCmd, uint8_t fanSpeedCmd, uint8_t temperatureCmd, uint8_t swingVCmd, uint8_t swingHCmd, bool powerfulCmd, bool quietCmd);
      |          ^~~~
lib/HeatpumpIR/HeatpumpIR.h:66:18: warning: 'virtual void HeatpumpIR::send(IRSender&, uint8_t)' was hidden [-Woverloaded-virtual=]
   66 |     virtual void send(IRSender& IR, uint8_t currentTemperature);
      |                  ^~~~
In file included from lib/HeatpumpIR/HeatpumpIRFactory.h:36:
lib/HeatpumpIR/VaillantHeatpumpIR.h:50:10: note:   by 'VaillantHeatpumpIR::send'
   50 |     void send(IRSender& IR, uint8_t powerModeCmd, uint8_t operatingModeCmd, uint8_t fanSpeedCmd, uint8_t temperatureCmd, uint8_t swingVCmd, uint8_t swingHCmd);
      |          ^~~~
lib/HeatpumpIR/HeatpumpIR.h:66:18: warning: 'virtual void HeatpumpIR::send(IRSender&, uint8_t)' was hidden [-Woverloaded-virtual=]
   66 |     virtual void send(IRSender& IR, uint8_t currentTemperature);
      |                  ^~~~
In file included from lib/HeatpumpIR/HeatpumpIRFactory.h:39:
lib/HeatpumpIR/KY26HeatpumpIR.h:67:8: note:   by 'void KY26HeatpumpIR::send(IRSender&, uint8_t, uint8_t, uint8_t, uint8_t, uint8_t, uint8_t, uint8_t, bool)'
   67 |   void send(IRSender &IR, uint8_t powerModeCmd, uint8_t operatingModeCmd,
      |        ^~~~
lib/HeatpumpIR/HeatpumpIR.h:65:18: warning: 'virtual void HeatpumpIR::send(IRSender&, uint8_t, uint8_t, uint8_t, uint8_t, uint8_t, uint8_t)' was hidden [-Woverloaded-virtual=]
   65 |     virtual void send(IRSender& IR, uint8_t powerModeCmd, uint8_t operatingModeCmd, uint8_t fanSpeedCmd, uint8_t temperatureCmd, uint8_t swingVCmd, uint8_t swingHCmd);
      |                  ^~~~
lib/HeatpumpIR/KY26HeatpumpIR.h:67:8: note:   by 'void KY26HeatpumpIR::send(IRSender&, uint8_t, uint8_t, uint8_t, uint8_t, uint8_t, uint8_t, uint8_t, bool)'
   67 |   void send(IRSender &IR, uint8_t powerModeCmd, uint8_t operatingModeCmd,
      |        ^~~~
TD-er commented 3 weeks ago

N.B. I made this commit to make it at least compile. Not sure if this does break something or whether the code was already broken...