ToniMacaroni / SaberFactory

A highly customizable custom saber mod for Beat Saber
GNU General Public License v3.0
241 stars 25 forks source link

[BUG] Saber modifiers with the same name causes target exception. #134

Open AlexxSeven opened 2 years ago

AlexxSeven commented 2 years ago

SF Version: 2.5.1 Game Version: 1.22.1

Steps to reproduce:

Console output: Console Output

This also inherently stops SF from exiting even if a different saber is chosen after the fact. It could be alleviated in the unity project side of things by having the exporter warn if two modifiers have the same name? Since this was with a saber I was working on, I was able to test the modifiers with different names to ensure that names were exactly what was causing it.

manel-graca commented 2 years ago

If it was me, first thing I would do was checking all my references to sabers and check if they are the same type. If they are the same, check all calls to sabers to make sure you are always calling it by the same type.