search

TonicAudio / Tonic

Easy and efficient audio synthesis in C++
The Unlicense
523 stars 63 forks source link

Merge development to master #192

Closed ndonald2 closed 11 years ago

ndonald2 commented 11 years ago

The current state of the development branch is pretty stable, IMO. I'd like to get it into master soon-ish.

The primary changes are:

@Dewb if there are still any loose ends for Windows that you'd like to get in before this goes to master, can you tie those up (ideally in the next few weeks)? Thanks.

Linux build configuration is getting closer but still needs some attention. Personally I'd prefer to put that off til a future merge in the interest of continuing to move things forward.

Dewb commented 11 years ago

Would you like the MIDI polysynth example in dev before merging? Right now it's still in a local branch. Main holdups are making sure it works on OSX, and deciding on a better way to organize all the standalone demos.

ndonald2 commented 11 years ago

If you're close to getting it working, then that would be cool to throw in. But if it's gonna take some time to get it working on OSX let's hold off for a future merge. I'm looking at this merge mostly as a core feature merge, but there's no reason we can't have more frequent demo updates going forward.

morganpackard commented 11 years ago

I'm pretty sure I'm going to want to change the return type of synth::publishChanges() soon. But that's a fairly obscure thing. If we're ok with Tonic releases not guaranteed to be 100% backward compatible for a while, I'm ok with the merge. Oh, also, I had a baby! He's awesome!

ndonald2 commented 11 years ago

@morganpackard That seems like a very lightweight change. If you can come up with a new name in the next few days that would be great. But if you're otherwise occupied with being a father (congratulations!!!) that's totally understandable. Alternatively you can just tell me what you want it renamed to and I can handle it.

@Dewb Do you have a branch with the polysynth demo on it? I'd be happy to take a stab at an XCode project (I'd love to check it out, too).

Dewb commented 11 years ago

@morganpackard Congrats!!!

@ndonald2 The polysynth branch is here: https://github.com/Dewb/Tonic/tree/midi An Xcode project should just be an hour or two of work, I just haven't had time to get to it with the first big Video Bleep deadline last week.

morganpackard commented 11 years ago

Don't want to just rename it. I want publishControlChanges to return the ControlChangeNotifier it creates, rather than the controlGenerator passed to it.

Sent from my iPhone

On Jul 10, 2013, at 11:31 AM, "Nick D." notifications@github.com wrote:

@morganpackard https://github.com/morganpackard That seems like a very lightweight change. If you can come up with a new name in the next few days that would be great. But if you're otherwise occupied with being a father (congratulations!!!) that's totally understandable. Alternatively you can just tell me what you want it renamed to and I can handle it.

@Dewb https://github.com/Dewb Do you have a branch with the polysynth demo on it? I'd be happy to take a stab at an XCode project (I'd love to check it out, too).

— Reply to this email directly or view it on GitHubhttps://github.com/TonicAudio/Tonic/pull/192#issuecomment-20750515 .

morganpackard commented 11 years ago

I'll take care of this publishControlChanges thing. Baby asleep on my lap. When he wakes up I'll teach him a little python. Or maybe ruby is a better starter language?

Just kidding. He needs to learn to play the accordion before he's allowed to program.

ndonald2 commented 11 years ago

Accordion -> Processing -> Python -> Assembly (he'll do fine)

morganpackard commented 11 years ago

I created a pull request for my tweak: #194 Once my tweak is pulled into development, I'm fine with development going into master.

morganpackard commented 11 years ago

Deleted #194. Please pull #195 before merging development with master.

ndonald2 commented 11 years ago

@morganpackard I made a small fix to novocaine for the iOS demo to run on hardware correctly. I'm working on something better to submit to the main novocaine repo.

If you're cool with everything I'm gonna go ahead and merge.

@Dewb I think the polyphonic demo can go in as a smaller merge in the near future, once we get an XCode version working too.

morganpackard commented 11 years ago

Do it!

On Fri, Jul 19, 2013 at 8:57 PM, Nick D. notifications@github.com wrote:

@morganpackard https://github.com/morganpackard I made a small fix to novocaine for the iOS demo to run on hardware correctly. I'm working on something better to submit to the main novocaine repo.

If you're cool with everything I'm gonna go ahead and merge.

@Dewb https://github.com/Dewb I think the polyphonic demo can go in as a smaller merge in the near future, once we get an XCode version working too.

— Reply to this email directly or view it on GitHubhttps://github.com/TonicAudio/Tonic/pull/192#issuecomment-21285487 .

Morgan Packard cell: (720) 891-0122 twitter: @morganpackard